rgommezz / react-native-scroll-bottom-sheet

Cross platform scrollable bottom sheet with virtualisation support, native animations at 60 FPS and fully implemented in JS land :fire:
MIT License
1.54k stars 66 forks source link

enableOverScroll is not working (tested on iOS) #48

Closed pasha-iwanov closed 4 years ago

pasha-iwanov commented 4 years ago

Current Behavior

At first, I want to say thank you all for such a great project. Finally some working scrollable sheets! But I cant make overscroll working on v0.7.0. Here is my code:

      <ScrollBottomSheet
        componentType="ScrollView"
        snapPoints={[40, windowHeight - 100]}
        initialSnapIndex={0}
        renderHandle={() => null}
        enableOverScroll
        showsVerticalScrollIndicator={false}
        animatedPosition={animatedPosition}
      >
        <View>{props.children}</View>
      </ScrollBottomSheet>

ScrollView is still not overscrolling. I've tried to check it in example code from README.md with enableOverScroll={true} prop, and have same behaviour: no overscrolling.

Your Environment

version
Platform (Android, iOS or both) iOS
react-native-scroll-bottom-sheet 0.7.0
react-native 0.61.5
react-native-gesture-handler 1.8.0
react-native-reanimated 1.13
pasha-iwanov commented 4 years ago

Ah, just ignore this. I thought that overscroll is for scroll bounce behaviour, but then I look inside sources and found that there is bounces={false} for all scrollable components.