rgonslayer / pe

0 stars 0 forks source link

Unable to add phone numbers beyond 8 digits #6

Open rgonslayer opened 2 years ago

rgonslayer commented 2 years ago

When trying to add phone numbers more than 8 digits, an error is given "Phone numbers should only contain numbers, and it should be 8 digits long".

As a global university with international students, there may be international applicants of scholarship without a local phone number. By disallowing phone numbers that are greater than 8 digits which is a compulsory field, it hinders rather than assist the administrative staff in their work.

Command used: add n/John Doe p/987654312 e/johnd@example.com s/NUS Global Merit Scholarship as/pending m/Medicine m/Computer Science

Screenshot 2022-11-11 at 16.47.05.png

Screenshot 2022-11-11 at 16.45.10.png

soc-pe-bot commented 2 years ago

Team's Response

justification for downgrading

Our team do acknowledge that we would like to be able to add phone numbers beyond 8 digits in further iterations (as mentioned in PED) but was unable to implement the above due to feature freeze in v1.4. However, this does not severely undermine the performance of TrackAScholar since the bulk of applications are local and normally contains 8 numbers.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Accepting only one phone number without warning

A user may provide two phone numbers for a contact (e.g., home phone and mobile phone). However, the add command will only accept the latter of the two supplied, without giving any warning.

image.png

See:

image.png


[original: nus-cs2103-AY2223S1/pe-interim#932] [original labels: type.FeatureFlaw severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Accepted as severity.Low Feature Flaw:

The team recognised that there has been no mention of this validation to the user. The team will make changes in future iterations to the documentations.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: As mentioned, there are international applicants and many of them have non-local numbers.

As shown below, there are around 20% international students in local universities. That means up to 1 in 5 scholarship applicants may have non-local numbers. When administrative staff are not able to enter a compulsory phone number data field, it prevents them from even tracking the applicant. If it were an optional field, this may be considered low severity but it is not hence it is medium severity.

https://www.todayonline.com/daily-focus/education/time-singapore-universities-admit-more-international-students Screenshot 2022-11-17 at 17.15.13.png