rgranadino / mage2_vagrant

Simple Magento 2 Vagrant Box
249 stars 68 forks source link

Provision notices #3

Closed Zifius closed 10 years ago

Zifius commented 10 years ago

During the vagrant up I got this error (twice actually):

Error: /bin/rm /vagrant/data/magento2/app/etc/local.xml returned 1 instead of one of [0] Error: /Stage[main]//Exec[remove-local-xml]/returns: change from notrun to 0 failed: /bin/rm /vagrant/data/magento2/app/etc/local.xml returned 1 instead of one of [0]

But overall it seem to provisioned succesfully

rgranadino commented 10 years ago

Hi @Zifius, I think this is because when the box provisions it tries to remove a local.xml file in the case where you might have destroyed it after having the application installed and then bring up the box again. If local.xml isn't removed then there could/will be issues during the install. Chances are the unless statement I'm using is returning a false positive and trying to remove a file that doesn't exist yet. I think I might look into hooks in vagrant to try and accomplish that part.

rgranadino commented 10 years ago

@Zifius I've updated the puppet manifest for the checks on when to remove local.xml after an initial provision. Thanks for reporting this, sorry it took a bit for me to get around to it.

Zifius commented 10 years ago

Thanks for the fix @rgranadino, provisions without notices now!