rgreen312 / OwlPlace

https://rgreen312.github.io/OwlPlace/
5 stars 1 forks source link

add error return values to interactions to consensus module #31

Closed jeffrey990219 closed 4 years ago

gvacaliuc commented 5 years ago

In order to differentiate between different types of errors, there are methods in the apiserver that should return error values. Specifically, GetLastUserModification.

It currently returns an empty string on all errors, but we should indicate what we're trying to convey with the empty string using an error value. In the case of this specific function, we'd either return a "user not found error" or "consensus error".

gvacaliuc commented 5 years ago

39 helps a bit with this, but we still can't distinguish between error types. I'm going to restructure some of the interactions with the consensus module and will fix this issue.