rgrempel / elm-route-url

Router for single-page-apps in Elm
http://package.elm-lang.org/packages/rgrempel/elm-route-url/latest
MIT License
196 stars 16 forks source link

Update sporto/erl dependency #28

Closed rgrempel closed 6 years ago

rgrempel commented 7 years ago

The sporto/erl dependency changed in version 11 to use a List (String, String) instead of a Dict to keep track of the URL's query.

This makes sense, since the query can have the same key twice (unlike a Dict).

It turns out to require a major version bump here, because of the signature of various functions in RouteUrl.Builder.

So, I should take care of that -- otherwise, people who use rgrempel/elm-route-url wouldn't be able to upgrade sporto/erl to version 11 and beyond.

robashton commented 7 years ago

And sadly there are bugs in version 10 (see #30) so a +1 from me on this one :(

MarkNijhof commented 7 years ago

+1