rgriebl / brickstore

An offline BrickLink inventory management tool.
https://www.brickstore.dev/
GNU General Public License v3.0
109 stars 27 forks source link

"Add to remark" option adds an extra space #853

Open Brickspert-au opened 3 months ago

Brickspert-au commented 3 months ago

When using the "add to remark" option there is an extra space being add into the remarks field before the remark being added and after the existing remark.

To Reproduce Steps to reproduce the behavior: in an open file with pieces added and something already in the remarks field

  1. highlight an item
  2. right click in the remarks field and select "Add to remark..."
  3. enter the desired text and click ok or press 'enter'
  4. notice how there is an unintentional space

Expected behavior There should be an unintentional space in the field before the add remark and after the existing remark

System information Please tell us which system you are running on and which BrickStore version you are using.

BrickStore 2024.3.1 (build: 1203)

Additional context Add any other context about the problem here. You can also attach BSX files, but GitHub only accepts these if added to a ZIP file first.

rgriebl commented 2 months ago

This is by design -- the add and remove functionality for the remarks and comments fields works on words, not characters. See also #553 Supporting this (as well as case-sensitivity) is not that easy though, as it requires custom dialogs to be implemented for both the desktop and mobile UI. I'll keep this open as a suggestion though.

ZZJHONS commented 2 months ago

On most programs the search and replace function works that way, Brickstore is the only one that I know of doesn't. To do a mass change in the remarks (or comments) I need to use another text editor. When I redistribute some section on my store I need to mass change remarks to add letters or numbers so when sorting orders by remark is all in a path. Also at the end of the remarks I store some data too.