search

rgrig / barista

fork of Barista, an OCaml library for handling Java bytecode
http://barista.x9c.fr/
GNU Lesser General Public License v3.0
1 stars 0 forks source link

big variants should not be in MLI #5

Open rgrig opened 12 years ago

rgrig commented 12 years ago

Recently, Rasmus solved a cyclic dependency between submodules of HighClass by separating types and operations into different modules. It might be a good idea to have one module with the types and one module with the operations: High and, respectively, HighOperations. (Each will have several submodules, such as High.Attribute, High.Instruction, and HighOperations.Attribute.)

The module High would have only an ml file, and no mli file. So we won't have to keep those huge variants in sync.

Related: https://github.com/rgrig/barista/issues/3

rgrig commented 12 years ago

type error should also go in High, with the types

rgrig commented 12 years ago

Many of the big variants are now moved into highTypes.ml. I leave this open because I think there are other types that should be moved.