search

rgrinberg / bencode

Bencode (.torrent file format) reader/writer in OCaml
24 stars 4 forks source link

make the lib depend on bytes; now compliant with -safe-string #3

Closed c-cube closed 9 years ago

c-cube commented 9 years ago

What the title says. We should be future-proof.

rgrinberg commented 9 years ago

Looks good. we need to update travis for 4.02 however. We might as well drop 4.01 support with the new version. What do you think?

c-cube commented 9 years ago

No, I don't think dropping support for older versions of OCaml is needed. The package bytes is designed to make it easy to support pre-4.02 versions. It's my fault the travis build failed (-safe-string is not a good idea now, we just want to be ready for when it becomes the default).

c-cube commented 9 years ago

It would be nice to release, after this. It's been a long time.

rgrinberg commented 9 years ago

Looks good! Sure I'll make a release promptly. By the way, if you want I can handover the repo to you if that would make the maintenance easier.

rgrinberg commented 9 years ago

Let's go for a 1.0.0? The interface has been frozen for long enough I'd say.

c-cube commented 9 years ago

Fine by me! The license change is nice, too.