rgrinberg / curly

Command line curl wrapper for OCaml
ISC License
42 stars 9 forks source link

4.08 update #13

Closed Leonidas-from-XIV closed 1 year ago

Leonidas-from-XIV commented 1 year ago

This PR updates the minimum version to 4.08 (safe since the only public dependency of curly, dune-release, is already using 4.08 as minimum).

This has some advantages:

There are some failing tests that have to be addressed though, but I'm putting the PR out there for discussion already.

Leonidas-from-XIV commented 1 year ago

Added another fix for the argument order in the tests (where expected and actual were flipped) and fixed the issue where -si was parsed as -s when not using a shell.

emillon commented 1 year ago

Can you split just upgrading to 4.08+ (result etc) and the shell thing in different PRs?

Leonidas-from-XIV commented 1 year ago

@emillon Sure, I've removed the commits from here and created #17 (to be rebased when this is merged).

emillon commented 1 year ago

Thanks