search

rgrinberg / onanomsg

nanomsg bindings for ocaml
Do What The F*ck You Want To Public License
38 stars 9 forks source link

Merge... #3

Closed vbmithr closed 9 years ago

vbmithr commented 9 years ago

Have a look… I think we should merge my fork. I changed the name to "nanomsg" though. Keep me up to date.

rgrinberg commented 9 years ago

Looks good. Does it make sense to rename the lib then? The O might be confusing now...

rgrinberg commented 9 years ago

I've added you as a collaborator as well.

rgrinberg commented 9 years ago

@vbmithr PS, how come cstruct was kicked out in favor of ccbigstring?

vbmithr commented 9 years ago

On 12/01/2015 20:19, Rudi Grinberg wrote:

@vbmithr https://github.com/vbmithr PS, how come cstruct was kicked out in favor of ccbigstring?

Ah, I did this because I prefer the bigstring interface of containers, (cstruct force to "make a cstruct out of a bigarray", and the functions acts on cstruct which includes offset and length), whereas a simple "bigstring" interface does not bundle the underlying string plus offset/length together.

Moreover there is no camlp4 dependency in containers (and containers is a cool lib IMO).

But cstruct was OK too. If you really have something against containers we can always change.

Cheers,

Vincent

avsm commented 9 years ago

Cstruct does that primarily for speed -- slicing a bigarray is a very slow operation, and Cstruct consumers typically do it a lot (and is just an OCaml allocation in Cstruct's case).

On 12 Jan 2015, at 19:36, Vincent Bernardoff notifications@github.com wrote:

On 12/01/2015 20:19, Rudi Grinberg wrote:

@vbmithr https://github.com/vbmithr PS, how come cstruct was kicked out in favor of ccbigstring?

Ah, I did this because I prefer the bigstring interface of containers, (cstruct force to "make a cstruct out of a bigarray", and the functions acts on cstruct which includes offset and length), whereas a simple "bigstring" interface does not bundle the underlying string plus offset/length together.

Moreover there is no camlp4 dependency in containers (and containers is a cool lib IMO).

But cstruct was OK too. If you really have something against containers we can always change.

Cheers,

Vincent — Reply to this email directly or view it on GitHub https://github.com/rgrinberg/onanomsg/pull/3#issuecomment-69630927.

rgrinberg commented 9 years ago

Both options are fine I'd say. Note that cstruct's camlp4 is optional now however.

@avsm I'm not sure we're slicing anything here either.