search

rgrinberg / onanomsg

nanomsg bindings for ocaml
Do What The F*ck You Want To Public License
38 stars 9 forks source link

1.0 fails to compile with recent ppx_deriving #8

Closed c-cube closed 8 years ago

c-cube commented 8 years ago

I think hygiene broke onano:

ocamlfind ocamldep -package containers.bigarray -package ctypes.foreign -package ipaddr -package containers -package lwt.unix -package lwt.ppx -package oUnit -modules lib_test/suite.ml > lib_test/suite.ml.depends
ocamlfind ocamldep -package containers.bigarray -package ipaddr -package containers -package ctypes -package ppx_deriving.std -modules lib/nanomsg.mli > lib/nanomsg.mli.depends
ocamlfind ocamldep -package containers.bigarray -package ipaddr -package containers -package lwt.unix -package lwt.ppx -package ctypes -package ppx_deriving.std -modules lib/nanomsg_lwt.mli > lib/nanomsg_lwt.mli.depends
ocamlfind ocamlc -c -g -bin-annot -safe-string -package containers.bigarray -package ipaddr -package containers -package ctypes -package ppx_deriving.std -I lib -I lib_test -o lib/nanomsg.cmi lib/nanomsg.mli
ocamlfind ocamlc -c -g -bin-annot -safe-string -package containers.bigarray -package ipaddr -package containers -package lwt.unix -package lwt.ppx -package ctypes -package ppx_deriving.std -I lib -I lib_test -o lib/nanomsg_lwt.cmi lib/nanomsg_lwt.mli
ocamlfind ocamlc -c -g -bin-annot -safe-string -package containers.bigarray -package ctypes.foreign -package ipaddr -package containers -package lwt.unix -package lwt.ppx -package oUnit -I lib_test -I lib -o lib_test/suite.cmo lib_test/suite.ml
+ ocamlfind ocamlc -c -g -bin-annot -safe-string -package containers.bigarray -package ctypes.foreign -package ipaddr -package containers -package lwt.unix -package lwt.ppx -package oUnit -I lib_test -I lib -o lib_test/suite.cmo lib_test/suite.ml
File "lib_test/suite.ml", line 29, characters 13-40:
Error: This expression has type
         Nanomsg.Addr.connect Nanomsg.Addr.t -> Ppx_deriving_runtime.string
       but an expression was expected of type
         Nanomsg.Addr.connect Nanomsg.Addr.t -> string
       Type Ppx_deriving_runtime.string is not compatible with type string 
Command exited with code 2.
c-cube commented 8 years ago

The current master seems to build properly (although the opam file should explicitely --enable-async or --disable-async), so a new release might fix that issue.

rgrinberg commented 8 years ago

@c-cube The local opam file has been fixed. Re-open if it wasn't. 1.1 isn't ready for release yet unfortunately though.

c-cube commented 8 years ago

Indeed, the master branch works now.