search

rgrinberg / opium

Sinatra like web toolkit for OCaml
MIT License
753 stars 68 forks source link

Fullsplat discarded #249

Closed reynir closed 3 years ago

reynir commented 3 years ago

I don't find much documentation on how the routes work, especially with splats (* and **).

https://github.com/rgrinberg/opium/blob/5e3d601a3ef7b9fdbcc7ea93fd698b6adc2a45c5/opium/src/route.ml#L83

I would expect we should add the rest of the URL path to matches.splat instead of ignoring it?

reynir commented 3 years ago

The line after has a comment that seem to me to describes exactly the opposite of what the code does :-)

https://github.com/rgrinberg/opium/blob/5e3d601a3ef7b9fdbcc7ea93fd698b6adc2a45c5/opium/src/route.ml#L84