Get ETag as LWT promise

rgrinberg / opium

Sinatra like web toolkit for OCaml

MIT License

753 stars 68 forks source link

Get ETag as LWT promise #267

Closed pkel closed 3 years ago

pkel commented 3 years ago

This PR changes the static middlewares' ETag argument from ?etag_of_fname:(string -> string option) to ?etag_of_fname:(string -> string option Lwt.t).

This change was proposed in #265.

tmattio commented 3 years ago

LGTM, can you add an entry in the changelog?

pkel commented 3 years ago

I pushed a proposal for the timestamp thing. On my end, Github does not show the latests commits as part of this PR. See https://github.com/pkel/opium/commit/342d7b6b665864896addb5745234cab7320ef781

Changelog entry in https://github.com/pkel/opium/commit/98baec542e76183d17d4060dbd7b8aa81c51eacf

tmattio commented 3 years ago

Thanks!