Stricter, up-front MIME type filtering.

rgrove / combohandler

A simple Yahoo!-style combo handler in Node.js.

MIT License

116 stars 32 forks source link

Stricter, up-front MIME type filtering. #10

Closed evocateur closed 12 years ago

evocateur commented 12 years ago

Deny requests with non-whitelisted or differing MIME types.
Short-circuit requests that have been truncated or otherwise mangled.
Tests!

Writing it as separate middleware did occur to me (extracting the MIME_TYPE config along with it), but for expediency's sake, it's inline.

rgrove commented 12 years ago

Thanks! I really do need to get middleware figured out, don't I.

evocateur commented 12 years ago

Yeah, this patch is even easier to envision as middleware than my other ones, except for the question of how to integrate it into the "main" combohandler middleware in a reasonable (lightweight, non-hacky) way...