search

rgrove / combohandler

A simple Yahoo!-style combo handler in Node.js.
MIT License
116 stars 32 forks source link

Add CLI and re-enable cluster #18

Closed evocateur closed 11 years ago

evocateur commented 11 years ago

I find myself fiddling with silly bits, like refactoring unreleased code incessantly. I need to start documenting and shipping instead of tweaking and procrastinating. Code review would be nice, if one has spare cycles.

The level of test coverage (which is now run & checked during Travis builds) in the cluster code leaves something to be desired, but it's tricky to test within the Mocha/Istanbul framework. In any case, the core cluster & CLI patterns have been in production at Zillow for over a year. If I keep noodling around with it in pursuit of nice green numbers, I may never ship these improvements.

Once I knock off the todo list, I'll be merging this in and publishing a minor release (0.3.0). There are no back-compat breaks that I am aware of, but a significant chunk of code such as this justifies more intentional upgrade decisions by consumers.

evocateur commented 11 years ago

Hah, whoops, the cluster tests that I do have cause the tests to fail due to differences in the Travis environment. :frowning:

rgrove commented 11 years ago

:thumbsup: