Serving binary assets - Githubissues

rgrove / combohandler

A simple Yahoo!-style combo handler in Node.js.

MIT License

116 stars 32 forks source link

Serving binary assets #28

Open netkgk opened 11 years ago

netkgk commented 11 years ago

Looks like combohandler doesn't serves binary files (images for example) properly, even though proper mime-type is provided via config. I.E. images are served broken due to pollution of original file. Using node v0.10.18.

evocateur commented 11 years ago

Combining binary data is outside the scope of this project. Does blindly concatenating binaries (i.e., images) even work?

netkgk commented 10 years ago

The point is to not concatenate binaries, but serve it as is, as yahoo combo handler does it.

rgrove commented 10 years ago

The Yahoo combo handler serves binary assets? That's news to me.