search

rgrove / crass

A Ruby CSS parser that's fully compliant with the CSS Syntax Level 3 specification.
MIT License
138 stars 14 forks source link

Minor changes which I think makes crass nicer #18

Closed stoivo closed 1 month ago

stoivo commented 2 months ago

For the last couple of days I have been looking at crass and how it parses CSS. I didn't end up making any big changes. I did some changed that I think is nice. I wonder if you are interested in merging any of these changed?

stoivo commented 1 month ago

Updated the PR to only two commit you wanted

However, I'm not interested in the refactoring in commits https://github.com/rgrove/crass/commit/91fe4208829f5766c9e152bcb63090ad750b457d and https://github.com/rgrove/crass/commit/6a71dd784e12c7874d7947f2d320f44270c6f1df. Those are semver-major changes that would break backwards compatibility, and I don't think they're necessary.

If I could make it so it isn't breaking semver would you like to include it then? 6a71dd784e12c7874d7947f2d320f44270c6f1df it easy to do without breaking semver. 91fe4208829f5766c9e152bcb63090ad750b457d can't be done without breaking semver but I don't think these methods was intendent to be public

stoivo commented 1 month ago

Do you think users are calling instance method consume_component_value and consume_declaration, and this is public api?