search

rgrove / jsmin-php

:skull: PHP port of Douglas Crockford's JSMin JavaScript minifier. No longer maintained.
423 stars 128 forks source link

Error when minify the jquery.mobile-1.0a3.js #6

Closed josepsanzcamp closed 13 years ago

josepsanzcamp commented 13 years ago

I try to minify the latest release of JQuery Mobile (jquery.mobile-1.0a3.js) and this is the error detected:

Fatal error: Uncaught exception 'JSMinException' with message 'Unterminated regu lar expression literal.' in /home/sanz/workspace/saltos/code/lib/jsmin/jsmin-1.1 .1.php:123 Stack trace: -0: /home/sanz/workspace/saltos/code/lib/jsmin/jsmin-1.1.1.php(235): JSMin->actio n(1) -1: /home/sanz/workspace/saltos/code/lib/jsmin/jsmin-1.1.1.php(64): JSMin->min() -2: /home/sanz/workspace/saltos/code/php/action/cache.php(62): JSMin::minify('/! ? \ jQuery M...') -3: /home/sanz/workspace/saltos/code/xml.php(77): include('/home/sanz/work...') -4: {main} thrown in /home/sanz/workspace/saltos/code/lib/jsmin/jsmin-1.1.1.php on line 1 23

Josep.

rgrove commented 13 years ago

Have you tried using the latest jsmin.php from git? This sounds like the issue that was fixed by this commit: https://github.com/rgrove/jsmin-php/commit/e71eac35ce7a0f191d199be9e35a8d12f1f999fd

josepsanzcamp commented 13 years ago

Hi.

Sorry by the question. With the latest jsmin.php works as expected. I get as reference the version string located found in the header file (1.1.1). I understand that I must compare the entire file to detect an update from your project.

Thanks and sorry for the inconvenience.

Josep.

rgrove commented 13 years ago

No worries.