Minify sync & phpdoc - Githubissues

rgrove / jsmin-php

:skull: PHP port of Douglas Crockford's JSMin JavaScript minifier. No longer maintained.

423 stars 128 forks source link

Minify sync & phpdoc #7

Closed andrerom closed 13 years ago

andrerom commented 13 years ago

Misc commits to try to slightly align code with minify's version of jsmin.php.

I'm not sure what the relation is between minify and jsmin-php project as I see you are active in both, but since this seems to be newer in some regards I did some minor alignment between the two. Hopefully they can be fully aligned in the future in some way, or doc/wiki added on which one to use or relation/difference between them.

rgrove commented 13 years ago

Thanks!

I handed Minify over to Steve Clay years ago, and pretty much everything that's awesome about it is stuff he's implemented since then. If I remember correctly, the jsmin.php in Minify is a fork of this one that Steve created since I wanted to keep my version a faithful port of jsmin.c rather than adding custom improvements.

andrerom commented 13 years ago

Ok, got it. Was some downstream request about adding these things from Steve's fork:

Comments containing IE conditional compilation are preserved, as are multi-line
comments that begin with "/*!" (for documentation purposes). In the latter case
newlines are inserted around the comment to enhance readability.

But might make sense to switch to that fork then, as they would require either adding it to jsmin.c first or deviate.