search

rgruebel / ha_zigbee2mqtt_networkmap

Custom Component for Homeassistant to show zigbee2mqtt Networkmap
169 stars 43 forks source link

make logbook more clear #2

Closed bbrendon closed 5 years ago

bbrendon commented 5 years ago

Right now when the update runs it updates the entity ID zigbee2mqtt_networkmap.last_update which is fine except when viewing the logbook it's very confusing. Changing the entity ID to zigbee2mqtt_networkmap.map_last_update makes it much less confusing.

bbrendon commented 5 years ago

Also, I think a capitol M in Map for the entity ID is bad form so I removed it though I'm not sure.

rgruebel commented 5 years ago

Thanks for your pull request. With the capital M I agree with you. We could also try to set the friendly_name of the entity, then it would not be a breakin change. What do you think?

bbrendon commented 5 years ago

Hmm. Either way. Since last_update is technically part of the zigbee2mqtt_networkmap domain I guess it would be okay. Usually stuff in HASS has a more generic domain though. I think a more "hass" like name would be networkmap.zigbee2mqtt_map_last_update.