search

rgthree / rgthree-comfy

Making ComfyUI more comfortable!
MIT License
980 stars 76 forks source link

Fast Groups... nodes cause VHS nodes to flicker #111

Closed moon47usaco closed 8 months ago

moon47usaco commented 8 months ago

Adding the Fast Groups nodes to a workflow with VHS nodes causes the video previews to flicker.

rgthree commented 8 months ago

Looks like a bug in VHS nodes. Specifically, this line: https://github.com/Kosinkadink/ComfyUI-VideoHelperSuite/blob/b86c1f9f4516faccb83c8957f0516443596def6b/web/js/VHS.core.js#L477C14-L477C25

Fast Groups Muter/Bypasser is using ComfyUI/LiteGraph's built in bounding calculation to determine group nodes, but VHS is doing something funky at that line above when the app requests the nodes' bounding box (which is what Fast Groups Muter/Bypasser does often).

rgthree commented 8 months ago

Filed a bug for VHS @ https://github.com/Kosinkadink/ComfyUI-VideoHelperSuite/issues/128