rgthree / rgthree-comfy

Making ComfyUI more comfortable!
MIT License
735 stars 62 forks source link

Feature suggestion: being able to dock group bypassers/muters #163

Open stephantual opened 4 months ago

stephantual commented 4 months ago

(credit: this was suggested to me by @davidwoods1337 on my youtube channel)

The idea is to allow the user to keep the muters/bypassers docked on screen. This would allow for the user to have all the switches at their disposal and maybe give them an option to minimize it.

I think it's a brilliant idea because this would bring us closer to 'comfy as an app using workflows' - which we could then standardize as creators and distribute.

Evidently, there might be limitations to comfy that prevents you from implementing this. In any case, I thought i'd mention it because your nodes are now pretty much omnipresent as they are so damn good! Cheers!

ghostsquad commented 3 months ago

I have the group muter copied in like 8 different places in my workflow, just so it's always visible depending on where I'm looking. Having this docked would be fantastic.

camoody1 commented 3 months ago

@stephantual Fantastic idea. +1

rgthree commented 3 months ago

This is a neat idea. Though it's not really that simple as ComfyUI's workflow area and the nodes within are all a custom rendering tied to a separate canvas object and not the browser window. The other docked items on screen (like the control panel, the rgthree-comfy progress bar, or the pysssss.ImageFeed, etc) are dockable because they aren't actually in the workflow and tied to that canvas object like all the nodes are.

However, I did just push a new feature that may help (though isn't exactly the same as a docked muter). It's a change to add a quick mute and/or bypass toggle to group headers because, as I believe part of this bug's intention, I wanted to quickly mute/bypass a group while looking at it directly and perhaps out of view from the Fast Groups Muter (and ComfyUI's right-click menu is crowded and too slow). Of course, it won't help if you want to toggle a group you're not looking at it.

Anyway, it's off by default, and you can turn it on in the rgthree-comfy settings (most quickly by right-clicking on the rgthree Progress Bar at the top of the screen and choose "Settings (rgthree-comfy)").

DrJKL commented 2 months ago

This could be another context submenu... How would you feel about adding a button to the control panel?

davidchenhs commented 1 month ago

There is a navigation in Easyuse nodes that follows the browser window. You can refer to it.