search

rgthree / rgthree-comfy

Making ComfyUI more comfortable!
MIT License
1.18k stars 84 forks source link

[Feature Request] Thumbnails in Power Lora Loader #223

Open Davikar opened 6 months ago

Davikar commented 6 months ago

The Power Lora Loader is great, but there's one key feature that is missing that's keeping me from using it everywhere... It would be nice if we could have thumbnails and lora info like there is in Pythongosssss lora loader, but for each lora. Now, I don't know how easy it would be to implement, but throwing out this suggestion here in case it's doable.

JorgeR81 commented 6 months ago

I vote for this ! If you use the Power Lora Loader, you have many loras, and it's easier to lose track of their names.

The Pythongosssss lora loader creates 2 files, per lora, in the models folder. One is for the image thumbnail, and another for extra data. You can add the thumbnail only on the loras you want. You can use the image from Civitai, but you can also add any image directly to the folder, with the same name as the lora. The other file it's created only if you select the option to view info on a specific lora. But the Pythongosssss lora loader, it's for a single lora, and it's even larger than the default loader.

Maybe you could just add an option to display those same jpeg images, added to the lora folder. The user could add the image directly to the folder, even without the Pythongosssss nodes.

As an extra feature, you could also add a way to read the file with the extra lora info. It would be nice if both nodes were able to create / read the same type of file, to avoid duplicated files.

loras

pg2

pg3

pg1

rgthree commented 6 months ago

The Power Lora Loader has some new changes coming soon that you folks will probably love :)

murphylanga commented 6 months ago

I am looking forward to it. If you work on it, maybe it will also be possible to output the Lora names and put them together.

The SD Prompt Saver from the SD Prompt Reader Nodes works very well with your nodes. The Lora model names can be stored in the image.

Davikar commented 6 months ago

Okay, just checked out the new changes and it's a nice implementation, but it's lacking some things that the pythongoss loaders have.

image

vs

image

Pythongoss version reads tags from the safetensor files, which are usually a lot more than what's listed on the civitai page. It also lists the base model and clip skip used for training the loras.

rgthree commented 6 months ago

Yes, the new dialog is also not the final version. Though, I was curious about the tags from the metadata. Do people actually find that useful? It's so exhaustive, I usually just trust what is outlined on civitai.

Anyway, this isn't the final dialog or power lora loader experience (and why I didn't post in here the last push :)

Davikar commented 6 months ago

Okay, well, the information on Civitai can be limited some times, the creators don't always write everything down. And a trigger word is just the topmost tag used in every training image, other tags are relevant too and allows you to use the lora better. Plus it's quicker to fire up the info dialog rather than having to load a civitai page just look something up. Idk, maybe I'm one of the few who looks at them, but it's a nice thing to have.

Davikar commented 5 months ago

It's pretty close to perfect now, only thing that is missing now is preview images in the lora list.

image

(Also, a minor nitpick... The list sorting seems to be case sensitive. I don't know what peoples opinion is on this, but none of the other lora loaders sort with case sensitivity.)

Piscabo commented 5 months ago

Just a quick question. With my one PC local ComfyUI setup, I can see the thumbnails as you scroll through the Lora list. My other setup has no thumbnails. Do I have to change a setting somewhere? They are both the newest. I update with manager daily.

Davikar commented 5 months ago

Just a quick question. With my one PC local ComfyUI setup, I can see the thumbnails as you scroll through the Lora list. My other setup has no thumbnails. Do I have to change a setting somewhere? They are both the newest. I update with manager daily.

The thumbnails are only available in the pythongoss lora loader right now.

Piscabo commented 5 months ago

Just a quick question. With my one PC local ComfyUI setup, I can see the thumbnails as you scroll through the Lora list. My other setup has no thumbnails. Do I have to change a setting somewhere? They are both the newest. I update with manager daily.

The thumbnails are only available in the pythongoss lora loader right now.

Then I have a magic node, but only on my one machine. image

rgthree commented 5 months ago

The pythongoss script may be hijacking the menu in one but not the other. Not sure why one case would, though.

I’ll see about adding it to the menu manually. I’m also working out a full-fledged Lora adding experience too.

JorgeR81 commented 4 months ago

In my case, the Power Lora Loader (rgthree) is displaying duplicate images, meant for the pythongosssss lora loader.

The image on the right, with the generation data, is the one fetched by the Power Lora Loader (rgthree).

The one left is a jpeg. It was created by pythongosssss lora loader, in the lora folder ( with the same name as the lora ). This image is used by pythongosssss lora loader to display a preview, as we mouseover the lora list ( see posts above ). But now it's also being displayed by the Power Lora Loader (rgthree).

The Power Lora Loader (rgthree) keeps displaying the duplicated image, even if the jpeg it's deleted on the lora folder. Is it possible to hide these duplicated jpeg images in the Power Lora Loader (rgthree) ?

img

HaydenReeve commented 3 weeks ago

The Power Lora Loader is my favourite node ever, as it just cleans up your workflow so much. I do agree that the ability to preview an image in the file selector is such an incredibly useful feature that is missing from the current implementation.

Off topic, but the only other thing on my wishlist would be keep the search bar searching the entire directory recursively.