rgthree / rgthree-comfy

Making ComfyUI more comfortable!
MIT License
1.23k stars 89 forks source link

please help i'm going crazy #382

Closed 4lt3r3go closed 1 day ago

4lt3r3go commented 3 days ago

First of all, thank you for all your amazing job on the nodes. and man i'm really sorry to bother here but i'm really going crazy to try solve this. Sorry again, I don’t khow were to contact you. tryed to use any switch and muter but coudnt achieve what i'm looking for.

I’ll try to explain as briefly as possible.

With all the video models available, some of them have the start and end frame functionality, like COGs. The problem is that the existing image switchers don’t allow leaving an empty option. Let me give you an example: if I want to select an image to be used as "end frame" picked from a series of images, I can use the image switcher. But if I don’t want any end frame (so give freedom to the model to end as he want) and thus leave the switcher unconnected to an image, the switcher locks up and freeze the workflow from proceeding.

Do you have any idea how to solve this issue? all switchers do not allow to pass a null

image

i tryed fast muter but the image still pass through even if is muted image

this damn COG module need to have litterally NOTHING connected to the "end frame" point. a reroute connected to nothiing is ok.

JorgeR81 commented 3 days ago

You can use an ImagePass node, and connect the Fast Muter to that node, instead.

pass

4lt3r3go commented 2 days ago

You can use an ImagePass node, and connect the Fast Muter to that node, instead.

just found a similar node right when you proposed image pass, wich is indeed more appropriate. ty🖤

now: any idea if fast muter can be controlled externally? convert widget to input is not an option there

4lt3r3go commented 2 days ago

because i suck in coding, I tryed to modify the fast muter with an LLM, to add "convert widget to input" but obviously I Failed miserably

JorgeR81 commented 2 days ago

any idea if fast muter can be controlled externally?

I know about 2 extensions that could to that.

They are both "wireless":


The Hub node allows you to add widgets from other nodes.

You could add a Fast Muter to a Hub node. And you could even add the note it's muting, if you want to !

h1


The Controller it's a new extension, with more features:

c01

c02

c00


In the Controller, the bypass/mute button has 3 states: 

p0

4lt3r3go commented 2 days ago

I really don’t know how to thank you for all the time you took to answer my question—truly, I’m on my knees. What I actually needed was...well.. Let me explain.

if the muter (or anything that can accomplish the task) receives a specific value, let's say "1" or "true", then should be muted. That’s why I was looking for a way to control it externally and transform the "enable/disable" option into a widget.

As for the rest, all these suggestions you gave me are incredibly useful, and I will definitely implement them. Thank you so much—truly, thank you!

4lt3r3go commented 2 days ago

i found a clumbsy workaround, with extra kilometric cables and stuff that do not require using it. So dont loose extra time with me but hey, if you have a solution to this and is simple to type then please go on. I will definetly use it Thank you again.

JorgeR81 commented 2 days ago

if the muter (or anything that can accomplish the task) receives a specific value, let's say "1" or "true", then should be muted. That’s why I was looking for a way to control it externally and transform the "enable/disable" option into a widget.

i found a clumbsy workaround, with extra kilometric cables and stuff that do not require using it.

You could try: https://github.com/chrisgoringe/cg-use-everywhere

The use-everywhere? node it's based on simple string widgets, to set connections.

If I change the text string ( e.g. from "Preview Image 2" to "Preview Image 3", ) it's like unplugging the wire.

You can use the text string you want, based on the name you have give to each group, node or input.


e1

rgthree commented 1 day ago

I would just put the image it in a group, and use the Fast Group Muter to mute it when you don't want an end frame.

But I'm not familiar with all the other extensions JorgeR81 has recommended.

4lt3r3go commented 1 day ago

Dear JorgeR81, you deserve statues and countless medals. I've been trying to solve this problem for a month without finding any solutions. You were the only one able to fix it.

I wish you lots of luck and an amazing career in life.

4lt3r3go commented 1 day ago

I would just put the image it in a group, and use the Fast Group Muter to mute it when you don't want an end frame. But I'm not familiar with all the other extensions JorgeR81 has recommended.

unfortunatly, for some reasons, the image keep pass through even if is muted but Jorge solved that way thanks guys

i can't believe. i finished my workflow. finally. i'm gonna cry now

image

JorgeR81 commented 1 day ago

I would just put the image it in a group, and use the Fast Group Muter to mute it when you don't want an end frame.

unfortunatly, for some reasons, the image keep pass through even if is muted but Jorge solved that way

@4lt3r3go, in case it helps, you can also put the ImagePass in a group, and use Fast Groups Muter.

g1