search

rgthree / rgthree-comfy

Making ComfyUI more comfortable!
MIT License
1.02k stars 77 forks source link

Node Disconnection from bypassers when used as a template (possible bug) #53

Closed aegis72 closed 8 months ago

aegis72 commented 10 months ago

image

The left side works as expected, but when I save this as a template, many of the effects nodes become disconnected from the bypassers, requiring a manual re-attachment for the bypasser to work again. At first, I put all the connections into a node collector, but then thinking that might be the issue, I hooked them right into the bypass repeater itself, which are connected to a "disable all fx" switches at the top, and then I also hooked them up so each effect can be bypassed/enabled individually.

All my reroutes are rerouteprimitive/pyssss versus native, as I read that disconnections can happen with the regular reroute.

When saved as a workflow, all is well - no issues. Only difference is that in the upper left, there's a connection point for an image, whereas in the full 'workflow" version, there's an Input LoadImage (The template version is designed to be chained, hence the difference).

Attached is the JSON from the Template if that helps. AegisFlow_MaskFX_Template.json

input files: maskfx swimsuit_watercolor horizontal mask

aegis72 commented 10 months ago

As a test, I went ahead and un-bypassed all the previously bypassed nodes, but it still drops all but two of the connections when saved as a template. For now, I've replaced the bypassers with a note explaining the possible issue.

image

aegis72 commented 10 months ago

The latest workflow (with the bypassers removed) AegisFlow_MaskFX_Template_bypassers_removed.json

aegis72 commented 9 months ago

image

Any ideas why this would happen?

aegis72 commented 8 months ago

It seems as if this is somehow fixed? Left is loaded as a workflow, right is added in as a template.

image

Any idea how that happened? was it in an update I just missed?

rgthree commented 8 months ago

Ah, this was probably fixed with https://github.com/rgthree/rgthree-comfy/commit/84cb989ca368e7482fc2c226a651e05c6ac4ab06 (and #76 probably could have been marked a duplicate).

Glad its working now!