search

rgugliel / CoxIter

CoxIter is a computer program designed to compute invariants of hyperbolic Coxeter groups.
GNU General Public License v3.0
6 stars 4 forks source link

windows compatible filenames #12

Closed drewitz closed 4 years ago

drewitz commented 4 years ago

Not that I'm able to compile it on Windows, but the asterisk doesn't seem to be allowed in filenames on windows. With these changes, you can at least clone the repo on Windows.

rgugliel commented 4 years ago

Hey Simon, Thanks for the PR!

Did you check that with these changes, the tests still run? Some of the graphs may be referred to in https://github.com/rgugliel/CoxIter/blob/master/testing/tests.txt

Eventually, I'd like to sync this change with https://github.com/rgugliel/AlVin/blob/master/quadraticinteger.cpp#L1005 since these graphs were produced with AlVin.

If you have time to do the corresponding PR that would be nice. Otherwise, I'll do it later this week.

Cheers

drewitz commented 4 years ago

ah, I didn't know about the tests... Yes, some of them are referred to in the file. I'm happy to also do PR in AlVin.