search

rgugliel / CoxIter

CoxIter is a computer program designed to compute invariants of hyperbolic Coxeter groups.
GNU General Public License v3.0
6 stars 4 forks source link

OpenMP not found on macOS #19

Closed drewitz closed 4 years ago

drewitz commented 4 years ago

cmake doesn't find OpenMP on macOS.

rgugliel commented 4 years ago

Can you provide the version of macOS? And eventual other relevant information (e.g., whether OpenMP was installed or not, ...)

drewitz commented 4 years ago

Currently I'm working on Catalina.

A first fix might be in drewitz/CoxIter@8a779d83fbe0d4286ee98387. It does compile with OpenMP but it seems to be slower for small graphs. Also need to install it via brew install libomp.

drewitz commented 4 years ago

Also without OpenMP it compiles perfectly fine. It just might be nice to have it actually running in parallel and faster also on macOS.

drewitz commented 4 years ago

I tested it on Linux and cleaned up the changes I made to CMakeLists.txt: drewitz/CoxIter@416c787ff260ae4643538945

OpenMP should be optional now. This could be reflected in the docs?

This fix is based on fix #16 (to be merged).

rgugliel commented 4 years ago

Solved by #16 , thanks!

drewitz commented 4 years ago

I just tried to install it on a Mac from scratch and the master branch didn't find openMP. It is not already solved by #16 but by drewitz/CoxIter@416c787 (will open a new pull request in a minute)