search

rgugliel / CoxIter

CoxIter is a computer program designed to compute invariants of hyperbolic Coxeter groups.
GNU General Public License v3.0
6 stars 4 forks source link

Modernize CMakeLists.txt #28

Closed szhorvat closed 10 months ago

szhorvat commented 10 months ago

This cleans up CMakeLists.txt a bit and makes it work on more systems, e.g. by explicitly looking for the header files that are used. (Now it works on my system, where libraries were installed with MacPorts.)

You may want to update the compilation instructions. I expect on most systems it should work with the following standard commands:

mkdir build && cd build
cmake ..
cmake --build .

If you want to add MacPorts instructions to the OS X section, the prerequisites can be installed with sudo port install cmake gmp pcre pari graphviz.

rgugliel-da commented 10 months ago

Thanks for the PR :) I'll check that it works on my system (Ubuntu), update the docs and then merge. If there is an issue, I'll come back to you.

szhorvat commented 10 months ago

Oops, I had a bit of a bug with the detection of PARI, which didn't show symptoms as the necessary include directories were already specified thanks to the other libraries (GMP, PCRE). There was also an unnecessary leftover line. These are now fixed in a second commit.