search

rh-aiservices-bu / fraud-detection

https://rh-aiservices-bu.github.io/fraud-detection/
Apache License 2.0
17 stars 56 forks source link

doc-fixes-2.5 #12

Closed MelissaFlinn closed 11 months ago

MelissaFlinn commented 11 months ago

@cfchase @erwangranger for your review

erwangranger commented 11 months ago

Looks good to me.

erwangranger commented 11 months ago

Actually, @MelissaFlinn , can you explain how these changes impact both locations: the official doc: https://access.redhat.com/documentation/en-us/red_hat_openshift_ai_self-managed/2-latest/html/fraud_detection_tutorial/index seems to talk about OpenShift AI. whereas the live build of these instructions (https://rh-aiservices-bu.github.io/fraud-detection/fraud-detection-workshop/index.html) still talks of OpenShift Data Science.

I don't see a reason for the rendered content to be different. Are you pulling remote content via antora and using different variables? Is that how it works?

MelissaFlinn commented 11 months ago

Hi @erwangranger for the product documentation, I run a fetch script to get these source files. We have a different build process so I only fetch fraud-detection-$branch/workshop/docs/modules/ROOT/pages/ and fraud-detection-$branch/workshop/docs/modules/ROOT/assets/images/ Then downstream, instead of the index file that is used here, we have a master.adoc file and assembly files

We use attributes to define the product name: productname-long and productname-short

I'll add a new commit here to fix the product name

MelissaFlinn commented 11 months ago

with this new commit - the new build here will show OpenShift AI instead of OpenShift Data Science