rh-aiservices-bu / fraud-detection

https://rh-aiservices-bu.github.io/fraud-detection/
Apache License 2.0
17 stars 56 forks source link

improve image in the doc word context #13

Closed tarilabs closed 11 months ago

tarilabs commented 11 months ago

First of all thank you for this great workshop tutorial!! 🚀

In the context of wording used in the current tutorial:

Set the value to Tensorflow with Cuda and Python 3.9 (UBI 9)

Screenshot 2023-12-14 at 14 42 34

I know one should read the manual, but I'm always preferring to look at the pictures (like a child 😅 ) and as I've run the pipelines I was met with the error of keras not found... which ultimately I did not set the pipeline file in the editor according to the text, but according to the image ...embarassing I know.

This PR proposed "a more explicit figure" so that people looking at either text or just the picture, won't miss it:

wb-pipeline-runtime-image
tarilabs commented 11 months ago

ie: if looking at the pictures and overlooking the text, would bump into

Exception encountered at "In [2]":
---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
Cell In[2], line 4
      2 import pandas as pd
      3 import datetime
----> 4 from keras.models import Sequential
      5 from keras.layers import Dense, Dropout, BatchNormalization, Activation
      6 from sklearn.model_selection import train_test_split

ModuleNotFoundError: No module named 'keras'

while PipelineRun

tarilabs commented 11 months ago

@cfchase I undestand I can ask for your review and if positive merge, please?

As noted in original message, thank you for this great workshop tutorial!! 🚀

cfchase commented 11 months ago

While I like it, I'm not sure if it's worth doing a more complex picture that will take more work to replace with newer screenshots. @MelissaFlinn @erwangranger opinions?

erwangranger commented 11 months ago

i'd say, merge it in as-is and we can re-simplify the screenshot next time we need to update it. I think a lot of people might run into this tomorrow, so it'd be nice to have fixed now.