search

rh-aiservices-bu / fraud-detection

https://rh-aiservices-bu.github.io/fraud-detection/
Apache License 2.0
17 stars 56 forks source link

Add meaningful example to the rest/grpc requests to the model #33

Closed esposem closed 5 months ago

esposem commented 5 months ago

We used this workshop for our Confidential Computing fraud detection use case, see https://www.redhat.com/en/blog/confidential-containers-fsi-public-cloud and https://www.youtube.com/watch?v=KXfnV8dqu0c.

In my opinion, having a more "concrete" example to show that the model does the correct reasoning would improve the understanding of the user. That's why I am proposing to add two examples in 3_rest_requests_multi_model.ipynb, 4_grpc_requests_multi_model.ipynb and 5_rest_requests_single_model.ipynb.

cfchase commented 5 months ago

@MelissaFlinn any input from docs?

MelissaFlinn commented 5 months ago

I made a few suggestions for changing the text - otherwise lgtm

cfchase commented 5 months ago

@MelissaFlinn @erwangranger made suggested text updates. I also fixed a weird difference in 4_grpc_requests_multi_model.ipynb that was not using prediction[0] and tested it out.

esposem commented 5 months ago

Well you didn't really have to apply the reviews for me, I could have easily applied them myself but hey, less work from my side :smile: Thanks a lot!