Fixes - Round1 - Githubissues

rh-aiservices-bu / jumpstart-library

GNU General Public License v3.0

52 stars 29 forks source link

Fixes - Round1 #18

Closed ksingh7 closed 3 years ago

ksingh7 commented 3 years ago

Added PGSQL service
fixed DB pwd as env

fixed async error (thought it needs to be tested). I am currently getting build errors

error: fatal: unable to update url base from redirection:
asked for: https://github.com/red-hat-data-services/jumpstart-library#ksingh-refactor/info/refs?service=git-upload-pack
redirect: https://github.com/red-hat-data-services/jumpstart-library

guimou commented 3 years ago

Can you just update your local main and rebase your modifications on it? I had already corrected the async issue in app.py, a few minutes before you made this PR. But also made some changes in the way the recognition function sends the results back (already json formatted because the json.dumps did not work with the promise from async). So it creates a conflict and the merge can not happen. If you do this you'll be able to merge directly, the other changes are good. Thanks!

ksingh7 commented 3 years ago

@guimou fixed as per your suggestion

ksingh7 commented 3 years ago

Also added kafdrop for edge/core instances