Closed dtrifiro closed 6 months ago
@guimou would appreciate if you could take a look.
tagging also @danielezonca in case he wants to have a look
I'm currently on PTO. It looks good, but I will fully review when I'm back next week.
On Tue., Nov. 21, 2023, 09:33 Daniele, @.***> wrote:
@guimou https://github.com/guimou would appreciate if you could take a look.
tagging also @danielezonca https://github.com/danielezonca in case he wants to have a look
— Reply to this email directly, view it on GitHub https://github.com/rh-aiservices-bu/llm-on-openshift/pull/23#issuecomment-1821040183, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA6C4YVJ4CCMNYZ47ZTJAXDYFS3U7AVCNFSM6AAAAAA7UV3X3SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRRGA2DAMJYGM . You are receiving this because you were mentioned.Message ID: @.***>
Hey @guimou have you got some time to have a look at this? Thanks!
Having just released
caikit-nlp-client
on PyPi, we can use that to abstract away some of the grpc code.See https://github.com/opendatahub-io/caikit-nlp-client for more details.