search

rh-hideout / pokeemerald-expansion

Feature branche for the pokeemerald decompilation. See the wiki for more info.
349 stars 1.04k forks source link

Not all mon elevation changes in #2021 were actually applied #2808

Open AsparagusEduardo opened 1 year ago

AsparagusEduardo commented 1 year ago

Major screw up on my part

hedara90 commented 1 month ago

Is this issue still relevant? When I looked through all sprites for #5178 I didn't see anything that looked incredibly off.

AsparagusEduardo commented 1 month ago

Is this issue still relevant? When I looked through all sprites for #5178 I didn't see anything that looked incredibly off.

I should've been more clear on what I mean by this. On merrp's branch, there was this PR that adjusted the elevation of overworld sprites so that they're aligned to the player's "floor": https://github.com/aarant/pokeemerald/pull/13

I had to use Rahtak's sprites from Team Aqua's Resource Repo in order to generate palettes via script, hence why they didn't have these changes.

AsparagusEduardo commented 1 month ago

Ah, i realize that this issue was duplicated. I'm posting the other issue's description that's more complete here #4776

Because of that, some sprites currently feel like they are positioned incorrectly compared to the player.

Should we add something to the Sprite Visualizer to indicate the "floor" they're relative to?