rh-hideout / pokeemerald-expansion

Feature branche for the pokeemerald decompilation. See the wiki for more info.
360 stars 1.09k forks source link

Fairy Lock can rotate pokemon's sprites when used #2845

Closed May8th1995 closed 10 months ago

May8th1995 commented 1 year ago

Shown in the video below. video

AsparagusEduardo commented 1 year ago

Can't confirm the issue, but the animation does look different than the one shown in the video.

Check how the animation looks like when the enemy uses it, to see if it behaves like how the video does.

LOuroboros commented 1 year ago

Can't confirm the issue, but the animation does look different than the one shown in the video.

Check how the animation looks like when the enemy uses it, to see if it behaves like how the video does.

Ah, I didn't notice. Will do. I'll post in 5 or 10 minutes with the result and post the bug with the animation on the opponent's end in a new ticket.

LOuroboros commented 1 year ago

So, yeah, the animation is still as bugged.

I'm not sure why, but after I used it against a Poochyena it also started to act even if the move is used by the Player.

mGBA_20230523_183255105 mGBA_20230523_183356426

cfmnephrite commented 1 year ago

Can I ask if Fairy Lock is supposed to look like that anyway? Minus the permanent sprite rotation, ofc

cfmnephrite commented 1 year ago

FIXED: https://github.com/cfmnephrite/pokeemerald/commit/5868aa01974b99e8842eec5ab7e10c1d11c22b72

AlexOn1ine commented 10 months ago

Closing because the bug comes from missing a correct animation. See dedicated issue #3021