rh-hideout / pokeemerald-expansion

Feature branche for the pokeemerald decompilation. See the wiki for more info.
360 stars 1.08k forks source link

Z-Moves and Disobedience break battles #3333

Closed pkmnsnfrn closed 1 month ago

pkmnsnfrn commented 1 year ago

Description

https://discord.com/channels/419213663107416084/774393519569502268/1145308711657676810

if you use a z-move when your mon doesn't obey you and ignore your orders, it causes various issues.

This ticket is a placeholder so we don't forget it, but needs to be fleshed out later.

Version

1.5.3 (Default)

Upcoming Version

No response

Discord contact info

aaghat

LOuroboros commented 1 year ago

I confirmed Z-Moves are certainly misbehaving with disobedient 'mons earlier, dropping a .gif over here:

mGBA_20230921_141226866

That Wurmple should have definitely not used a Z-Move, lel.

EDIT: Future Edu from 2024-09-09 here: Discord seemingly removes GIFs after a while when pasted in outside sources, so I uploaded the gif from that day directly to GitHub.

DizzyEggg commented 1 year ago

How does it work in the official games? Can Z-moves even fail to disobedience or they always work?

pkmnsnfrn commented 1 year ago

@DizzyEggg I don't have a way to test it right now, but I would bet any amount of money that vanilla games will check for obedience and print the string for failure before anything else, and if the Pokemon passes the obedience check, THEN the mon will "surround itself with Z-Power and unleash the full force Z Move"

LOuroboros commented 1 year ago

How does it work in the official games? Can Z-moves even fail to disobedience or they always work?

They can, yeah.

https://github.com/rh-hideout/pokeemerald-expansion/assets/4485172/bfb8efe5-8338-4aa8-94ae-2277dad66df8

AlexOn1ine commented 11 months ago

How does it work in the official games? Can Z-moves even fail to disobedience or they always work?

They can, yeah. usum.mp4

Are you allowed to use the z-move again if it the mon didn't obey the first time the z move was chosen?

LOuroboros commented 11 months ago

How does it work in the official games? Can Z-moves even fail to disobedience or they always work?

They can, yeah. usum.mp4

Are you allowed to use the z-move again if it the mon didn't obey the first time the z move was chosen?

Yes. You can keep trying to use a Z-Move until it activates.

https://github.com/rh-hideout/pokeemerald-expansion/assets/4485172/44101a93-5f68-4375-9536-13657852e8e8

Bassoonian commented 3 months ago

zmoveobedience

Confirmed to still be an issue after #4449, albeit without "various issues"