search

rh-hideout / pokeemerald-expansion

Feature branche for the pokeemerald decompilation. See the wiki for more info.
364 stars 1.14k forks source link

ALWAYS_CRIT is misleading #3771

Closed AsparagusEduardo closed 10 months ago

AsparagusEduardo commented 10 months ago

Description

Gens 2-5 don't guaranteee that a critical hit always happens if the ratio is 3. image image

The use of that define should be reverted.

Version

1.7.0 (Default)

Upcoming Version

No response

Discord contact info

AsparagusEduardo

AlexOn1ine commented 10 months ago

Should the define be just removed?

AsparagusEduardo commented 10 months ago

Should the define be just removed?

Not only that, but a flag should be added to replace the EFFECT_ALWAYS_CRIT effect, something like criticalHitAlways.

By the way, Zippy Zap is missing its pre-Gen 8 effect. image

EDIT: and change critBoost to criticalHitStage.

AlexOn1ine commented 10 months ago

Not only that, but a flag should be added to replace the EFFECT_ALWAYS_CRIT effect, something like criticalHitAlways

Oh, now I see what you mean.

Bassoonian commented 10 months ago

Fixed by #3779