search

rh-hideout / pokeemerald-expansion

Feature branche for the pokeemerald decompilation. See the wiki for more info.
361 stars 1.11k forks source link

Hard Level Caps Issues #4378

Closed WillKolada closed 6 months ago

WillKolada commented 6 months ago

Description

If a Pokemon gains enough experience all at once, it can overlevel the current cap. For example, if the cap is 15 and I have a level 14 Bulbasaur that gains 2000+ experience, I can shoot right past 15 into 16 and beyond. This seems like it would be tricky to address while still accurately reporting gained experience in the actual battle text, admittedly.

Additionally, if you have both Hard Level Caps and Gen 5/7+ Scaled Experience enabled, then when a Pokemon at or past the current level cap would earn experience in battle, instead of earning 0, it earns 1. This appears to be due to how ApplyExperienceMultipliers accounts for large experience values if Gen 5/7+ Scaled Experience is enabled.

Version

1.8.1 (Latest release)

Upcoming/master Version

4363

Discord contact info

Special K#8400

AlexOn1ine commented 6 months ago

If a Pokemon gains enough experience all at once, it can overlevel the current cap. For example, if the cap is 15 and I have a level 14 Bulbasaur that gains 2000+ experience, I can shoot right past 15 into 16 and beyond. This seems like it would be tricky to address while still accurately reporting gained experience in the actual battle text, admittedly.

XP Candies have the same issue.