rh-hideout / pokeemerald-expansion

Feature branches for the pokeemerald decompilation. See the wiki for more info.
310 stars 826 forks source link

PNG validator and fixer for pngs in the expansion #4775

Open hedara90 opened 3 weeks ago

hedara90 commented 3 weeks ago

Description

Currently gbagfx is generating errors bit continuing anyway if the errors don't affect the finished .4bpp image. Some images also contain unnecessary data such as EXIF and embedded thumbnails among others. EXIF data might also contain identifiable information about whoever created the png. All data except for the header, IHDR, PLTE, IDAT and IEND is extraneous and might hide problems with the image when opened in editors. For example the tRNS chunk might hide an improperly colored background.

Either integrating a validator/fixer into gbagfx or writing a new tool would work.

Things found so far in PNGs don't have to be there:

Discord contact info

hedara

Bassoonian commented 3 weeks ago

I think gbagfx improvements would be warmly welcomed over at pret