rh-hideout / pokeemerald-expansion

Feature branche for the pokeemerald decompilation. See the wiki for more info.
347 stars 1.03k forks source link

Revert wrongly done reversion #4857

Closed AlexOn1ine closed 3 months ago

AlexOn1ine commented 3 months ago

Reverts wrongly done reversion by me.

Corrected a bunch of tests that were wrongly written but I had to add one 'KNOW_FAILING' to one test. The comment should explain why.

Intimidate activates immediately after the mon was switched in as long as other battles still have to do their turn

Also some old test marked by #4856 as KNOWN_FAILING were removed but not the new ones. Those still didn't pass.

Sorry again Egg. If I'm about to do something like this I will consult you first.

Sneed69 commented 3 months ago

Shouldn't most of these actually trigger against an empty field?

AlexOn1ine commented 3 months ago

Shouldn't most of these actually trigger against an empty field?

Afaik not in new games.

AlexOn1ine commented 3 months ago

sorry for the force push :eyes: