rh-hideout / pokeemerald-expansion

Feature branche for the pokeemerald decompilation. See the wiki for more info.
362 stars 1.12k forks source link

Current sprite issues #5135

Open hedara90 opened 2 months ago

hedara90 commented 2 months ago

Description

Followers

Battle sprites

Discord contact info

hedara

Cafeei commented 2 months ago

I've looked at Gen 5 followers and found some other issues with them:

hedara90 commented 2 months ago

I've looked at Gen 5 followers and found some other issues with them:

Updated list with these observations.

hedara90 commented 2 months ago

Apparently I hadn't updated the list fully, now it should be done. Added a bunch of observations for gen 1-4.

hedara90 commented 1 month ago

Incredible work from Liamjd14 in adding the Gen 9 overworld sprites and being patient with me complaining about singular pixels.

5304 Closes out the single biggest checkmark on this list.

Liamjd14 commented 1 month ago

Just created a draft pull request that is designed to fix some of the follower sprites that have problems. Will keep updating it with more infomation as i add more fixes to it.

hedara90 commented 1 month ago

Is there a way to prevent repeated efforts for this? As was the case for #5332 and #5333 Commenting here with sprites that people are working on or something.

Liamjd14 commented 1 month ago

Will comment here any of the changes i work on in future. Is it worth me closing my previous pull request due to the overlap. I will update this comment when its done. Currently working on / plan on working on : Raichu-Alola follower shiny a bit too sunburnt and ears/tail too light -done Sandshrew-Alola follower ear anim south - done Vulpix-Alola follower east/west blinking pixels - done Ninetales-Alola follower south blinking pixels - done Persian-Alola follower east/west could have a less pointy face - done Graveler-Alola follower blinking pixels - done Golem-Alola follower blinking pixels - done Exeggutor-Alola follower stray pixels on north sprite - done Marowak-Alola follower fire color, shiny palette slightly off - done Ponyta-Galar follower shiny hair too yellow - done Rapidash-Galar follower shiny hair too yellow - done Growlithe-Hisui follower blinking pixels south sprite - done Arcanine-Hisui follower blinking pixels - done Typhlosion-Hisui follower shiny stomach color wrong - done Sliggo-Hisui follower normal palette spots wrong color - done Goodra-Hisui follower throat goo missing - done Dialga-origin follower shiny missing - done (based of shiny battler) Palkia-origin follower shiny missing - Sprite and pallets reworked to allow for shiny, might need a second pass Shaymin-sky follower sprite missing - done (custom sprite based off of hgss sprite) Basculin-white follower shiny missing - done Sawsbuck-Winter follower blinking pixels, horns have transparent pixels - Done Tornadus-Therian follower sprite missing Thundurus-Therian follower sprite missing Landorus-Therian follower sprite missing Enamorus-Therian follower shiny missing Kyurem-White follower sprite missing - done (see below for credits) Kyurem-Black follower sprite missing - done (see below for credits) Keldeo-Reolute follower sprite missing Flabebe-all follower shiny flower stem - done Floette-Eternal follower shiny wrong palette - done Pumpkaboo/Gourgeist sizes missing sprites - Done Zydog follower missing sprite - done (see below for credits) Oricorio-pompom/pa'u/sensu follower missing sprite - done (see below for credits) Necrozma-Dawn Wings follower blinking pixel south sprite above right eye - done Toxtricity-LK follower missing shiny - done Calyrex-Rider follower missing shiny (gold cape/crown) - done Raticate-Totem follower missing sprite - done Mimikyu-Totem follower missing sprite - done Marowak-Totem follower missing sprite - done Partner Pikachu follower missing sprite - done Partner Eevee follower missing sprite - done Toxtricity-LK-Gmax has a follower sprite? Why? - done Magearna-OC follower missing palette (sprite is the same as base) - done

Also added a fix for the lycanroc midday issue, and sprites for the east/west asym for scovillain and tinkaton line (when the code is there it can be usdated to work in game)

kittenchilly commented 1 month ago

Blaziken's female sprite should have smaller head spikes (or whatever they are called)

iriv24 commented 1 month ago

melmetaltransparent

Melmetal overworld sprite has some transparent pixels

hedara90 commented 1 month ago

Hedara is currently working on: Melmetal, done Tepig, done Pignite, in-progress Abomasnow Ambipom, male Doduo, male Snover, male Garchomp, male Ledian, male