rh-hideout / pokeemerald-expansion

Feature branche for the pokeemerald decompilation. See the wiki for more info.
353 stars 1.06k forks source link

Berry Mutations always yield a Persim Berry #5432

Open pkmnsnfrn opened 2 weeks ago

pkmnsnfrn commented 2 weeks ago

Description

According to sBerryMutations, there are no permutations of berries that should create the Persim Berry.

Whenever a berry is planted, grown and picked OR picked from vanilla AND when Mutations are turned on, a Persim Berry is granted as the mutation.

I believe this means there are two at least problems:

Replication

wget https://files.catbox.moe/4cnxn0.inc -O data/scripts/debug.inc && wget https://files.catbox.moe/l0focv.h -O include/config/overworld.h

Steps

  1. Start a new game
  2. Run Debug > Scripts > Script 1
  3. Pick Oran Berry on Route 104 (Expected just Oran Berry, also got Persim Berry)
  4. Pick Cheri Berry on Route 104 (Expected just Oran Berry, also got Persim Berry)
  5. Plant Lum Berry
  6. Plant Sitrus Berry
  7. Plant Liechi Berry
  8. Plant Ganlon Berry
  9. Run Debug > Utilities > Berry Functions > Ready Map Trees
  10. Pick all trees, observing they all yield Persim berries as well as original Berry
  11. Plant any Berry
  12. Water planted Berry
  13. Run Debug > Utilities > Berry Functions > Grow Map Trees
  14. Repeat 11 and 12 3 more times
  15. Pick trees, observing they all yield Persim berries as well as original Berry
  16. Run Debug > Scripts > Script 2
  17. Pick any Berry on Route 123 (Expected just single Berry, also got Persim Berry)

Videos

Ready Map Trees

https://github.com/user-attachments/assets/0ca8edb3-c91c-4848-91fa-140f63278beb

Grow Map Trees

https://github.com/user-attachments/assets/df3138bd-d2cf-41ea-bab4-5622dffaa120

Vanilla Trees

https://github.com/user-attachments/assets/a30d1352-977b-46e1-89a0-8fbe0156de1f

Version

upcoming (Edge)

Upcoming/master Version

No response

Discord contact info

pkmnsnfrn

sixtycardpickup commented 2 weeks ago

I've got this one too, if that helps to confirm bug status.