search

rh-hideout / pokeemerald-expansion

Feature branche for the pokeemerald decompilation. See the wiki for more info.
369 stars 1.19k forks source link

Shadows for all 'mons interact badly with trainerslide messages #5565

Open hedara90 opened 1 month ago

hedara90 commented 1 month ago

Description

Discovered by Mystic Gohan on discord. Tested and verified by hedara.

https://github.com/user-attachments/assets/9b893aa6-cbf1-4ac4-9f26-6bec815c9bfc

The shadow of the active 'mon will move over to the trainer sprite during a trainerslide, usually in the wrong place for the trainer.

Version

upcoming (Edge)

Upcoming/master Version

No response

Discord contact info

hedara

AsparagusEduardo commented 2 weeks ago

Do we want to keep the milestone for this issue? #5632 already added a warning for this, and I can imagine that it's a small enough issue that it's non-blocking for 1.10's release.

kittenchilly commented 2 weeks ago

Didn't we disable shadows by default because of this though?

AsparagusEduardo commented 2 weeks ago

That's why I'm asking if it's a good enough of a patch to free a release. I'm still working on the script to migrate the chages from 1.9 to 1.10 in gSpeciesInfo and the current PRs, so this doesn't need to be decided now.

Pawkkie commented 2 weeks ago

I would absolutely agree that it's not 1.10 blocking, we wanted to have 1.10 out more than a week ago and I don't think delaying it for anything that isn't explicitly gamebreaking at this point is worthwhile.