search

rh-integration / IntegrationApp-Automation

Sample Integration application along with lifecycle automation
Apache License 2.0
13 stars 9 forks source link

added 3scale toolbox Jenkins pipelines to publish API on 3scale and improvements in readme files #21

Closed redhatHameed closed 5 years ago

redhatHameed commented 5 years ago

[WIP] added 3scale toolbox Jenkins pipeline to publish API on 3scale and improvements in readme files

Signed-off-by: Abdul Hameed ahameed@redhat.com

redhatHameed commented 5 years ago

Good stuff! I will only note that there is a substantial amount of whitespace changes, much of it likely the result of an IDE/code formatter, that makes it hard to review the changes. One solution is to first do a global code format in one commit, and the actual changes in a second commit of the same PR, to avoid this problem.

@bmozaffa yup these happen in result with code formatter - you can ignore them by going in "Diff settings", "Hide whitespace changes", and then "Apply and reload". diff Let me if this something will work

nmasse-itix commented 5 years ago

This PR will fix #18

redhatHameed commented 5 years ago

@nmasse-itix added application plans with pricing rules import from artifact file, Please review when you have time and merge it if it looks good.

nmasse-itix commented 5 years ago

Very good @redhatHameed ! 👍Let's merge this !