rh-jmc-team / jigawatts

Build a jar file for easier access to CRIU from Java
Other
11 stars 5 forks source link

Make an OSGi bundle #8

Closed tjwatson closed 4 months ago

tjwatson commented 3 years ago

I would like to use this library as an OSGi bundle. This PR adds the necessary meta-data to build an OSGi bundle:

This PR also includes adding common patterns to exclude to the .gitignore.

It also fixes the RandomTest package name. This test is in the package directory for org/checkpoint but it was using the default (empty) package name in the source. While javac and the maven usage of the java compiler cares nothing about the directory .java source files are located, I know some IDEs will give errors by default if it detects this type of thing. I think it would be nice to follow the convention if possible.

judovana commented 3 years ago

Hi! Pls wait with merging this untill javac -h is merged. As it is now moreover show stopper. If you can extract the test and sahde->jar hunks to separate PRs, woudl be awesome, as they can be merged asap. (Unlike the rest)

judovana commented 2 years ago

If you are still interested in osgi binding, I would be happy to finish the review.