search

rh-lab-q / remote-dependency-solving

GNU General Public License v3.0
10 stars 1 forks source link

CMakeLists.txt creates directories out of the build directory #96

Open kdudka opened 8 years ago

kdudka commented 8 years ago

The CMake script should not write to file system out of the build directory. IMO the following two lines are inappropriate for a script that is supposed to be run by trustful developers:

file(MAKE_DIRECTORY /tmp/ssds/)
file(MAKE_DIRECTORY /var/cache/ssds/packages/)

https://github.com/rh-lab-q/server-side-dependency-solving/blob/fb901f3e1c89b90b9d08b8a3ecc183c9e6ada45a/CMakeLists.txt#L196