search

rh-messaging / artemis-prometheus-metrics-plugin

Apache License 2.0
22 stars 20 forks source link

Improve poms and update to Java 11 #15

Closed EdwardKuenen closed 1 year ago

brusdev commented 1 year ago

@EdwardKuenen thanks for splitting your changes on multiple commits. Do you mind if I amend your commit message before merging your PR to Update poms to Java 11 (of course I will not change the commit author)?

jbertram commented 1 year ago

LGTM

brusdev commented 1 year ago

@EdwardKuenen I amended your commit using git commit --amend (of course I didn't change the commit author) and then I pushed your branch with the force option using git push ekuenen only-pom-improvement -f, I'll merge this PR in 1h unless you have any concerns.

EdwardKuenen commented 1 year ago

Thank you very much! Will there be a new release of this version?

brusdev commented 1 year ago

@EdwardKuenen thanks for your contribution, I should create a release tag tomorrow.