search

rh-messaging / artemis-prometheus-metrics-plugin

Apache License 2.0
22 stars 20 forks source link

Add broker name to jvm metrics #16

Closed naude-r closed 1 year ago

naude-r commented 1 year ago

currently the jvm metrics do not include the broker name. this is causing an issue when creating dashboards as the instance tag added by prometheus may not align with the broker name.

this might be as simple as: meterRegistry.config().commonTags("broker", "XXXX");

not sure how to query the current server instance to get to the broker....

brusdev commented 1 year ago

@naude-r this seems more an issue for the Apache ActiveMQ Artemis MetricsManager.

naude-r commented 1 year ago

@brusdev thank you, you are right. will log an issue with the artemis team.

naude-r commented 1 year ago

ARTEMIS-4291 logged

brusdev commented 1 year ago

@naude-r are you planning to create a PR to fix ARTEMIS-4291?

naude-r commented 1 year ago

@brusdev yes, that is the plan.

naude-r commented 1 year ago

PR 4487 submitted.

a new method, bind, was added to ActiveMQMetricsPlugin (default empty implementation). this was needed to make the order more explicit.

naude-r commented 1 year ago

ARTEMIS-4291 merged for next release.

part of the above discussion resulted in additional metrics being added as well: ARTEMIS-4292 merged and available.

brusdev commented 1 year ago

@naude-r great work!!!

gauravtayade11 commented 1 year ago

@brusdev not getting jar and war file in repo

brusdev commented 1 year ago

@gauravtayade11 this repository is supported by Red Hat, you can download the artifacts from the Red Hat public maven repository, i.e. https://maven.repository.redhat.com/ga/com/redhat/amq-broker/artemis-prometheus-metrics-plugin/2.0.0.redhat-00002/artemis-prometheus-metrics-plugin-2.0.0.redhat-00002.jar https://maven.repository.redhat.com/ga/com/redhat/amq-broker/artemis-prometheus-metrics-plugin-servlet/2.0.0.redhat-00002/artemis-prometheus-metrics-plugin-servlet-2.0.0.redhat-00002.war