search

rh-messaging / artemis-prometheus-metrics-plugin

Apache License 2.0
22 stars 20 forks source link

broker.xml: tag changed from metrics-plugin to metrics/plugin #7

Closed 2019-05-10 closed 2 years ago

2019-05-10 commented 2 years ago

With Artemis 2.18.0 the tag

<metrics-plugin class-name="org.apache.activemq.artemis.core.server.metrics.plugins.ArtemisPrometheusMetricsPlugin"/>

changed to

<metrics>
  <plugin class-name="org.apache.activemq.artemis.core.server.metrics.plugins.ArtemisPrometheusMetricsPlugin"/>
</metrics>
brusdev commented 2 years ago

The metrics-plugin element has been deprecated in favor of the metrics element since 2.14 but it is still usable for backward compatibility.

2019-05-10 commented 2 years ago

No doubt, but 2.14 is almost one and half a year old, and current is 2.19.0. So, as documentation goes, shouldn't it target installation in a fairly recent version?

brusdev commented 2 years ago

I'm not sure to get the point, the latest documentation points to the new element: metrics-plugin https://activemq.apache.org/components/artemis/documentation/latest/metrics.html#configuration

brusdev commented 2 years ago

Maybe you was talking about the README.md of this repository.

In this case feel free to send a PR to update it, I'll merge it.

brusdev commented 2 years ago

README updated