rh-openjdk / MSITests

MIT License
1 stars 2 forks source link

re-introduced tester as current user name default value #32

Closed RadekCap closed 1 year ago

RadekCap commented 1 year ago

In previous changes, we introduced the usage of $USER and removed the default tester fallback.

For the Adoptium run is better to let this fallback so this reverts previous changes related to the default user.

judovana commented 1 year ago

I agree with tester being default, however do not have storng opinion. What impact the user have to the runtime? it is usually expected that it should be current user.

judovana commented 1 year ago

Can you please elaborate on real impact of user to the testsuite? Afaik the user should have no impact, so the previous setup was better.

judovana commented 1 year ago

Please?

RadekCap commented 1 year ago

yy, of course, sorry for delay.

I updated readme about real impact of user to the testsuite which is:

Use CURRENT_USER_NAME for definiton of user under which the tests will run. This is used as the root directory for installation, saving logs etc. Default: tester

However it still needs update imho.

I'll update "This is used as the root directory for installation, saving logs etc." to something like "User home folder is used as the root directory for installation, saving logs etc. Testsuite require to have full access right here."

judovana commented 1 year ago

Tha saving destination may be got from globally known $HOME directory, and user may remain default. WDYT?

judovana commented 1 year ago

I actually nowhere see su tester or similarly. I think framework shoudl run ok under any - that measn current - user.

RadekCap commented 1 year ago

Tha saving destination may be got from globally known $HOME directory, and user may remain default. WDYT?

We are running tests in three different environments currently. It looks like a good tradeoff to define where we can store artifacts directly.

I don't see a reason to use $HOME. It's similar to using $USER and then finding that it isn't working because Adoptium infrastructure doesn't define it.

RadekCap commented 1 year ago

I actually nowhere see su tester or similarly. I think framework shoudl run ok under any - that measn current - user.

Probably I don't understand this note. Framework is running under the current user. Again, this is here because we need a safe path for installation, saving installation logs, etc.

judovana commented 1 year ago

Then maybe the variable can be rename dto DEFAU_SAVE_NAME or similarly if you get my point?

RadekCap commented 1 year ago

Then maybe the variable can be rename dto DEFAU_SAVE_NAME or similarly if you get my point?

That was my repeated suggestion. We are going to discuss today our sync with the Adoptium side.

The test suite will need small adjustments in paths then but no big deal. I do no have an opinion here so if there won't any reaction from Adoptium I update it as you suggested. Thanks.

judovana commented 1 year ago

cool! TY!

RadekCap commented 1 year ago

Created #34